-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dynamic parameters and maps #498
base: main
Are you sure you want to change the base?
Conversation
@cloudwebrtc What are your thoughts on the effort on this and if you are willing to consider it? All the types are already defined in JsSip for example https://github.com/versatica/JsSIP/blob/master/lib/RTCSession.d.ts |
@victortive Yea i like this, recently when working with this package all the maps and whats being passed in where has been hell. |
I just did terminate options, but the main problem is the webrtc library also relies on maps. Both need to be updated |
@victortive Hmm ohk, well ive just been made a maintaner so im like sweet lets get this package alive and going with updates |
Fixes #497